Fix AppReproducersTest#timezonesBakedIn #287
Conversation
With GraalVM prior to 24.2.0 the default locale (and included locale) for a native image was determined by the -Duser.language and -Duser.country settings as image build time. With GraalVM >= 24.2.0 the build settings of language/country have no effect in terms of included locales in the resulting native image. Therefore, -H:IncludeLocales, needs to be used at build time instead. Also at image runtime the default language is determined by the system locale. For the purpose of the test we'd want the French language which we need to set at image runtime when the test runs. Closes: Karm#285
There was a problem hiding this comment.
LGTM. I am just wondering whether we should instead fix this on the Quarkus side by adding user.language-user.country to the included locales like we do for quarkus.default-locale and quarkus.native.user-language-quarkus.native.country in quarkusio/quarkus#43448
Thanks for the review.
I'm not sure we should. Having the build system locale included by default isn't something which I think all users are aware of. Maybe raise as an issue and see what the desired outcome of it is. |
Done in quarkusio/quarkus#43533 |
|
@Karm OK with this? CI looks good too :) |
With GraalVM prior to
24.2.0the default locale (and included locale) for a native image was determined by the -Duser.language and -Duser.country settings as image build time. With GraalVM>= 24.2.0the build settings of language/country have no effect in terms of included locales in the resulting native image. Therefore,-H:IncludeLocales, needs to be used at build time instead. Also at image runtime the default language is determined by the system locale. For the purpose of the test we'd want the French language which we need to set at image runtime when the test runs.Tested with
GraalVM community 23+37(which uses the old scheme) and with a latest JDK 24-based mandrel build which uses the new scheme. Both pass.24.1:
24.2
Closes: #285