Skip to content

feat: Pass error label to component #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siyavash4812 wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

feat: Pass error label to component #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4c63e5e
Added props to allow users pass in custom error labels
siyavash4812 Mar 20, 2023
622dbaa
Updated readme
siyavash4812 Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,7 @@ export default DragDrop;
| handleChange | function | function that will be called when the user selects or drops file(s) | `(file) => console.log(file)` |
| onDraggingStateChange | function | function that will be called with the state of dragging | `(dragging) => console.log(dragging)` |
| dropMessageStyle | CSS Properties | A CSS property to style the hover message | `{backgroundColor: 'red'}` |
| errorLabel | string | text appears if there is an error | `"File type/size error"` |

## How to contribute:
- Please follow the instructions inside this file: [here](CONTRIBUTION.md)
Expand Down
15 changes: 10 additions & 5 deletions src/FileUploader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ type Props = {
fileOrFiles?: Array<File> | File | null;
disabled?: boolean | false;
label?: string | undefined;
errorLabel?: string | undefined;
multiple?: boolean | false;
required?: boolean | false;
onSizeError?: (arg0: string) => void;
Expand All @@ -40,6 +41,7 @@ type Props = {
* @param typeError - boolean to check if the file has type errors
* @param disabled - boolean to check if input is disabled
* @param label - string to add custom label
* @param errorLabel - string to add custom error label
* @returns JSX Element
*
* @internal
Expand All @@ -50,10 +52,11 @@ const drawDescription = (
uploaded: boolean,
typeError: boolean,
disabled: boolean | undefined,
label: string | undefined
label: string | undefined,
errorLabel: string | undefined
) => {
return typeError ? (
<span>File type/size error, Hovered on types!</span>
<span>{errorLabel || "File type/size error, Hovered on types!"}</span>
) : (
<Description>
{disabled ? (
Expand Down Expand Up @@ -100,7 +103,8 @@ const drawDescription = (
label,
multiple,
required,
onDraggingStateChange
onDraggingStateChange,
errorLabel
}
* @returns JSX Element
*/
Expand All @@ -124,7 +128,8 @@ const FileUploader: React.FC<Props> = (props: Props): JSX.Element => {
multiple,
required,
onDraggingStateChange,
dropMessageStyle
dropMessageStyle,
errorLabel
} = props;
const labelRef = useRef<HTMLLabelElement>(null);
const inputRef = useRef<HTMLInputElement>(null);
Expand Down Expand Up @@ -243,7 +248,7 @@ const FileUploader: React.FC<Props> = (props: Props): JSX.Element => {
<>
<ImageAdd />
<DescriptionWrapper error={error}>
{drawDescription(currFiles, uploaded, error, disabled, label)}
{drawDescription(currFiles, uploaded, error, disabled, label, errorLabel)}
<DrawTypes types={types} minSize={minSize} maxSize={maxSize} />
</DescriptionWrapper>
</>
Expand Down