Merge pull request active-elastic-job#80 from marcgreenstock/add_dela…

…y_too_long_error

RangeError is too general for the 15 minute max delay

lib/active_job/queue_adapters/active_elastic_job_adapter.rb

@@ -76,6 +76,18 @@ def initialize(message_id, calculated, returned)
         end
       end
 
+      # Raised when the delay is longer than the MAX_DELAY_IN_MINUTES
+      class DelayTooLong < RangeError
+        def initialize()
+          super(<<-MSG)
+            Jobs cannot be scheduled more than #{MAX_DELAY_IN_MINUTES} minutes
+            into the future.
+            See http://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API_SendMessage.html
+            for further details!
+          MSG
+        end
+      end
+
       def enqueue(job) #:nodoc:
         self.class.enqueue job
       end
@@ -147,12 +159,7 @@ def queue_url(queue_name)
         def calculate_delay(timestamp)
           delay = (timestamp - Time.current.to_f).to_i + 1
           if delay > MAX_DELAY_IN_MINUTES.minutes
-            msg = "Jobs cannot be scheduled more than " <<
-            "#{MAX_DELAY_IN_MINUTES} minutes into the future. " <<
-            "See http://docs.aws.amazon.com/AWSSimpleQueueService/latest/APIReference/API_SendMessage.html" <<
-            " for further details!"
-
-            raise RangeError, msg
+            raise DelayTooLong.new
           end
           delay = 0 if delay < 0
           delay

spec/active_job/queue_adapters/active_elastic_job_adapter_spec.rb

@@ -93,8 +93,9 @@ def initialize; end;
     context "when scheduled timestamp exceeds 15 minutes" do
       let(:delay) { 16.minutes }
 
-      it "raises a RangeError" do
-        expect { adapter.enqueue_at(job, timestamp) }.to raise_error(RangeError)
+      it "raises a DelayTooLong" do
+        expect { adapter.enqueue_at(job, timestamp) }
+          .to raise_error(ActiveJob::QueueAdapters::ActiveElasticJobAdapter::DelayTooLong)
       end
     end
   end