Fix NPC crashes with new SpellEffects and refactor healing & knockback logic #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugs fixed:
PredicateStunnedOrSleeping,PredicateUnableToCastSpells) to explicity return TRUE only for effects that actually block behaviorThis removes unintended runtime crashes while preserving vanilla behavior
Healing modifier logic bug FIX
Entity.ApplyHealingModifiersFormula:
This matches standar RPG behavior and prevents edge cases (e.g 100% reduction always blocks healing)
Knockback double-application & desync
Im still with troubles for fix this, and im searching new ways for solve this
Proyectile spells with knockback were aplying displacement:
This caused:
FIX:
Migration cleanup:
20251212000000_AddCombatEffectsAdded fields:
Combat_KnockbackTiles(int)Combat_PercentageEffect(int?)Verification
NOTES: