fixes for good sensorless #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bwnance
force-pushed
the
sensorless_fixes
branch
from
3b0d571 to
5c1d8bb
Compare
Contributor
Author
|
@nielsvz if you have a second, please test this! |
Contributor
I tested the proposed changes with the following settings: [tmc5160 stepper_x]
current_change_dwell_time: 2.0
home_current: 2.0
run_current: 2.8
[stepper_x]
homing_positive_dir: True
homing_retract_dist: 5
homing_retract_speed: 20
homing_speed: 100
min_home_dist: 40
second_homing_speed: 100
use_sensorless_homing: TrueLooks like this works 👍
|
Contributor
Author
|
@nielsvz awesome, thank you! |
Contributor
|
Awesome, any plan to merge this in master branch ? |
Contributor
yes, I am doing some final tests this week and it should be merged soon |
rogerlz
force-pushed
the
sensorless_fixes
branch
2 times, most recently
from
e0ca3b8 to
7da6e25
Compare
rogerlz
force-pushed
the
sensorless_fixes
branch
from
7da6e25 to
a88db72
Compare
rogerlz
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.