Skip to content

Conversation

@bwnance
Copy link
Contributor

@bwnance bwnance commented Sep 29, 2024

Makes the homing constants,
HOMING_START_DELAY, ENDSTOP_SAMPLE_TIME, and ENDSTOP_SAMPLE_COUNT configurable from danger_options

lowering ENDSTOP_SAMPLE_COUNT to 1 should likely resolve some probing drift some users have been observing

Checklist

  • pr title makes sense
  • squashed to 1 commit
  • added a test case if possible
  • if new feature, added to the readme
  • ci is happy and green

@bwnance bwnance requested a review from a team as a code owner September 29, 2024 18:12
@bwnance bwnance force-pushed the configurable_endstop_constants branch from 4271f72 to bff7a8d Compare September 29, 2024 18:21
@rogerlz rogerlz merged commit ad6f972 into master Oct 2, 2024
@rogerlz rogerlz deleted the configurable_endstop_constants branch October 2, 2024 18:14
@miklschmidt
Copy link
Contributor

Mainline bug report: Klipper3d/klipper#6711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants