Custom threshold for PROBE_POINTS_INCREASING check on QGL and Z_TILT #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
That's really nice! Can you please fix the conflict and squash the commits? |
rogerlz
reviewed
Apr 3, 2024
rogerlz
reviewed
Apr 3, 2024
Member
Author
|
Where the hell did this conflict come from, I actually just merged my master on my fork with DK master and then based the branch off of that, well maybe gut f'ed up. |
Zeanon
force-pushed
the
increasing_threshold
branch
2 times, most recently
from
07e3830 to
fad0757
Compare
Zeanon
force-pushed
the
increasing_threshold
branch
from
fad0757 to
1c0ff13
Compare
rogerlz
approved these changes
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned by some people, a way to adjust the threshold would be preferred over just ignoring the check, so here we go