Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lint about constructor names that hide default constructor names (fix #26) #32

Merged
merged 5 commits into from
Nov 6, 2023

Conversation

nemakin
Copy link
Contributor

@nemakin nemakin commented Oct 26, 2023

It reports using default constructor names, such as Error, Ok, Some, None in user-defined types.

@nemakin nemakin requested a review from Kakadu as a code owner October 26, 2023 15:16
@nemakin nemakin force-pushed the master branch 2 times, most recently from f357920 to b23b09e Compare October 26, 2023 16:46
CHANGES Outdated Show resolved Hide resolved
Copy link
Owner

@Kakadu Kakadu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ещё стоило бы добавить типы с явным реэкспортом, и посмотреть, что на них не ругается

type 'a maybe = 'a option = None | Some of 'a

@Kakadu Kakadu marked this pull request as draft October 26, 2023 18:33
Nikita Nemakin added 2 commits November 2, 2023 14:01
Signed-off-by: Nikita Nemakin <nemakin.nikita@yandex.ru>
…re bad

Signed-off-by: Nikita Nemakin <nemakin.nikita@yandex.ru>
src/untyped/dune Outdated Show resolved Hide resolved
Signed-off-by: Nikita Nemakin <nemakin.nikita@yandex.ru>
@Kakadu Kakadu marked this pull request as ready for review November 6, 2023 12:33
@Kakadu Kakadu merged commit 70fa043 into Kakadu:master Nov 6, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants