Skip to content

Conversation

rwc9u
Copy link

@rwc9u rwc9u commented Dec 12, 2020

Add support for outputting junit formatted xml that handles the multiple suites per rspecq run, handles the potential for retries, and updates outputted xml appropriately.

@rwc9u rwc9u requested a review from jacobthemyth December 12, 2020 09:27
@rwc9u
Copy link
Author

rwc9u commented Dec 12, 2020

The following is a build using this version of rspecq and one parallel process per container.

https://app.circleci.com/pipelines/github/Kajabi/kajabi-products/32667/workflows/99b7c4be-024d-4dd1-974e-3a017bbacb0b/jobs/107585/steps

I think I need to tweak my example rejection a little bit because there are still some duplicate failures shown.

Copy link

@jacobthemyth jacobthemyth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this approach, it's much more pragmatic than what I suggested and follows the existing pattern of extending behavior by adding a formatter.

@rwc9u rwc9u marked this pull request as ready for review December 15, 2020 17:56
@rwc9u rwc9u changed the title WIP - Add support for outputting junit formatted xml for CI Add support for outputting junit formatted xml for CI Dec 15, 2020
@rwc9u rwc9u merged commit 5316d7c into master Dec 15, 2020
@rwc9u rwc9u deleted the add-job-to-junit-file branch December 15, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants