Skip to content

Conversation

@pixelflips
Copy link
Member

@pixelflips pixelflips commented Jan 22, 2026

Description

Rolls back typescript-eslint packages from v8 to v6 with proper version compatibility to resolve linting and spec errors that appeared after the recent upgrade. The v8 upgrade introduced compatibility issues that caused CI failures in new PRs.

Changes:

  • @typescript-eslint/eslint-plugin: ^8.0.06.6.0
  • @typescript-eslint/parser: ^8.0.06.6.0 (matched with eslint-plugin for consistency)
  • @stencil-community/eslint-plugin: ^0.10.0^0.8.0

Why 0.8.0 for stencil plugin?

Version compatibility matrix:

  • 0.5.0 requires typescript-eslint ^5.x (incompatible with v6)
  • 0.8.0 requires typescript-eslint ^5.x || ^6.x ✅ (proper compatibility)
  • 0.10.0 requires typescript-eslint ^7.x || ^8.x (incompatible with v6)

Using v0.8.0 provides:

  • ✅ Proper peer dependency compatibility (no --legacy-peer-deps needed)
  • ✅ Bug fixes and improvements over 0.5.0
  • ✅ Matched typescript-eslint versions (both 6.6.0)
  • ✅ Avoids v8 breaking changes

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Verified locally that linting and specs pass after rollback:

  • npm run lint.all - passes with no errors (only pre-existing warnings)
  • ✅ Verified correct versions installed:
    • @typescript-eslint/eslint-plugin: 6.6.0
    • @typescript-eslint/parser: 6.6.0
    • @stencil-community/eslint-plugin: 0.8.0
  • ✅ Proper peer dependency compatibility (no invalid warnings)

Test Configuration:

  • Pine versions: 3.14.0
  • OS: macOS
  • Browsers: N/A (tests run in headless mode)
  • Screen readers: N/A
  • Misc: No longer requires --legacy-peer-deps (proper compatibility)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@netlify
Copy link

netlify bot commented Jan 22, 2026

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit 998d3ed
🔍 Latest deploy log https://app.netlify.com/projects/pine-design-system/deploys/69726d3e5c7952000777d574
😎 Deploy Preview https://deploy-preview-641--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added bug Something isn't working package: core Changes have been made to the Core package labels Jan 22, 2026
Rolls back typescript-eslint from v8 to v6 and updates to compatible plugin versions to resolve linting and spec errors in CI.

Changes:
- @typescript-eslint/eslint-plugin: ^8.0.0 → 6.6.0
- @typescript-eslint/parser: ^8.0.0 → 6.6.0 (matched with eslint-plugin)
- @stencil-community/eslint-plugin: ^0.10.0 → ^0.8.0

Version 0.8.0 of the stencil plugin properly supports typescript-eslint v6 (0.5.0 requires v5, 0.10.0 requires v7/v8). This provides proper peer dependency compatibility without --legacy-peer-deps while maintaining bug fixes from newer stencil plugin versions.
@pixelflips pixelflips force-pushed the fix/rollback-typescript-eslint branch from b4ec5ee to 998d3ed Compare January 22, 2026 18:32
@pixelflips
Copy link
Member Author

@coderabbitai please review

@coderabbitai
Copy link

coderabbitai bot commented Jan 22, 2026

@pixelflips: I'll review the changes in this PR.

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link

coderabbitai bot commented Jan 22, 2026

📝 Walkthrough

Walkthrough

This pull request modifies the libs/core/package.json file to adjust three development dependencies. The @stencil-community/eslint-plugin version is downgraded from ^0.10.0 to ^0.8.0, while @typescript-eslint/eslint-plugin and @typescript-eslint/parser are both downgraded from ^8.0.0 to 6.6.0. No changes are made to publicly exported entity declarations or signatures. The total change involves 3 lines modified.

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: rolling back typescript-eslint to v6 to resolve linting and spec errors.
Description check ✅ Passed The description includes comprehensive sections covering the change rationale, dependency updates with compatibility reasoning, testing verification, and completed checklist items.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@pixelflips pixelflips marked this pull request as ready for review January 22, 2026 18:58
@pixelflips pixelflips self-assigned this Jan 22, 2026
@pixelflips pixelflips merged commit a352abd into main Jan 22, 2026
15 checks passed
@pixelflips pixelflips deleted the fix/rollback-typescript-eslint branch January 22, 2026 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working package: core Changes have been made to the Core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants