Skip to content

Conversation

@pixelflips
Copy link
Member

@pixelflips pixelflips commented Jan 12, 2026

Description

When pds-dropdown-menu-item has an href, the inner link's clickable area didn't include the item's padding, making the hit target smaller than the visual hover state. This updates the link styling to fill the entire menu item area and removes the default underline to match design spec.

Fixes DSS-68

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • unit tests
  • tested manually

When hovering a menu-item with link, verify the full area is clickable

Test Configuration:

  • Browsers: Chrome

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • My changes generate no new warnings
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@pixelflips pixelflips self-assigned this Jan 12, 2026
@netlify
Copy link

netlify bot commented Jan 12, 2026

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit 10b41f9
🔍 Latest deploy log https://app.netlify.com/projects/pine-design-system/deploys/6965892db6d2720008d70d13
😎 Deploy Preview https://deploy-preview-630--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@pixelflips pixelflips marked this pull request as ready for review January 12, 2026 23:52
@github-actions github-actions bot added the package: core Changes have been made to the Core package label Jan 12, 2026
@pixelflips pixelflips merged commit 1ddfded into main Jan 13, 2026
15 checks passed
@pixelflips pixelflips deleted the style/menu-item-link branch January 13, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core Changes have been made to the Core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants