style: update alert dark mode link hover style #620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for pine-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
github-actions
bot
added
bug
QuintonJason
force-pushed
the
fix/alert-dark-mode-link-hover
branch
from
8eb5adc to
db30680
Compare
pixelflips
approved these changes
Jan 8, 2026
Member
pixelflips
left a comment
pixelflips
left a comment
There was a problem hiding this comment.
One small comment on toast, otherwise LGTM! 👍🏼
Comment on lines
12
to
13
| --pds-context-link-color: var(--pine-color-text-inverse); | ||
| --pds-context-link-color-hover: var(--pine-color-text-inverse-emphasis); |
Member
There was a problem hiding this comment.
Do these actually get used? They dont seem to be used within the stylesheet. I am not sure they are needed here since the alert links already use --pine-color-text-primary.
| <DocCanvas | ||
| mdxSource={{ | ||
| react: `<pdsAlert heading="Alert heading text" variant="default"> | ||
| react: `<PdsAlert heading="Alert heading text" variant="default"> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #(issue)
Type of change
How Has This Been Tested?
Click the dark mode toggle -> Visit the alert page -> Small with actions -> hover link
Test Configuration:
Checklist:
If not applicable, leave options unchecked.