-
Notifications
You must be signed in to change notification settings - Fork 1
style: address transform minification warnings #612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for pine-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
📝 WalkthroughWalkthroughThis pull request modifies dark-mode styling selectors across three component stylesheets. In Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
🔇 Additional comments (4)
Comment |
Description
Fix CSS nesting warnings that appear when running Storybook. The
[data-theme="dark"] &nesting syntax requires the:is()pseudo-class transformation, which is not supported in the configured target browsers (chrome87, edge88, firefox78, safari14).Fixes DSS-40
Updated selectors to use compatible patterns:
:host-context([data-theme="dark"]) &(consistent with existing patterns)[data-theme="dark"] .classType of change
How Has This Been Tested?
Test Configuration:
Checklist: