Skip to content

Conversation

@QuintonJason
Copy link
Contributor

Description

  • Box - resolve core spacing values not resolving to proper corresponding CSS to resolve reported issue

Fixes DSS-38

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Visit the Box view -> Using Core Spacing Tokens

  • tested manually

Test Configuration:

  • Pine versions:
  • OS:
  • Browsers:
  • Screen readers:
  • Misc:

Checklist:

If not applicable, leave options unchecked.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@QuintonJason QuintonJason self-assigned this Dec 12, 2025
@github-actions github-actions bot added bug Something isn't working package: core Changes have been made to the Core package labels Dec 12, 2025
@netlify
Copy link

netlify bot commented Dec 12, 2025

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit 73bfa01
🔍 Latest deploy log https://app.netlify.com/projects/pine-design-system/deploys/693c8dd25fe71300086cf180
😎 Deploy Preview https://deploy-preview-611--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@QuintonJason QuintonJason marked this pull request as ready for review December 15, 2025 19:50
Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@QuintonJason QuintonJason merged commit 0e04d50 into main Dec 15, 2025
15 checks passed
@QuintonJason QuintonJason deleted the fix/update-box-spacing-values branch December 15, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working package: core Changes have been made to the Core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants