Skip to content

Conversation

@QuintonJason
Copy link
Contributor

Description

There are several components that need semantic variables:

  • table
  • select
  • button
  • tab
  • tabs

Fixes DSS-21

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests you've added and run to verify your changes.
Provide instructions so that we can reproduce.
Please also list any relevant details for your test configuration.

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Test Configuration:

  • Pine versions:
  • OS:
  • Browsers:
  • Screen readers:
  • Misc:

Checklist:

If not applicable, leave options unchecked.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@netlify
Copy link

netlify bot commented Nov 26, 2025

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit 01fa036
🔍 Latest deploy log https://app.netlify.com/projects/pine-design-system/deploys/69271355f47c7e0008bbf00d
😎 Deploy Preview https://deploy-preview-597--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added bug Something isn't working package: core Changes have been made to the Core package labels Nov 26, 2025
@QuintonJason QuintonJason changed the title fix: update semantic tokens in SCSS files fix: update semantic and core tokens in SCSS files Nov 26, 2025
@QuintonJason QuintonJason marked this pull request as ready for review November 26, 2025 20:07
@QuintonJason QuintonJason self-assigned this Nov 26, 2025
@QuintonJason QuintonJason merged commit f6f3843 into main Dec 3, 2025
17 checks passed
@QuintonJason QuintonJason deleted the fix/semantic-tokens branch December 3, 2025 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working package: core Changes have been made to the Core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants