Skip to content

Conversation

@pixelflips
Copy link
Member

@pixelflips pixelflips commented Nov 21, 2025

Description

Updated Figma Code Connect files for pds-link, pds-divider, and pds-progress components to match recent Figma component updates by the design team.

Note

The updates are already published to Figma and can be verified there.

Changes:

  • pds-link: Added missing variants (inline, inverted), fixed color mapping (destructivedanger), and added sm size option
  • pds-divider: Fixed property name from BleedOffset (capitalized) and added all new size options (xxs, xs, sm, md, lg, xl)
  • pds-progress: Fixed property name capitalization (Progress, Label, Completion) and properly mapped "Top floating" and "Bottom floating" variants to use pds-tooltip composition pattern

These updates resolve validation errors that prevented publishing Code Connect mappings to Figma.

Fixes:

  • DSS-16
  • DSS-17
  • DSS-18

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other: Validated and published to Figma Code Connect successfully

Test Configuration:

  • Pine versions: Current
  • OS: macOS
  • Browsers: N/A (Figma Code Connect validation)
  • Screen readers: N/A
  • Misc: Tested via Figma Code Connect CLI publish command

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@pixelflips pixelflips self-assigned this Nov 21, 2025
@netlify
Copy link

netlify bot commented Nov 21, 2025

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit 21783bd
🔍 Latest deploy log https://app.netlify.com/projects/pine-design-system/deploys/691fb1d26fcaa70008a86e18
😎 Deploy Preview https://deploy-preview-595--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added bug Something isn't working package: core Changes have been made to the Core package labels Nov 21, 2025
@pixelflips pixelflips marked this pull request as ready for review November 21, 2025 00:19
@pixelflips pixelflips merged commit 78c41cf into main Nov 21, 2025
17 checks passed
@pixelflips pixelflips deleted the fix/update-code-connect-latest branch November 21, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working package: core Changes have been made to the Core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants