Skip to content

fix(pds-accordion): add accordion-icon part for styling #572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pixelflips merged 1 commit into from
Oct 30, 2025
Merged

fix(pds-accordion): add accordion-icon part for styling #572

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion libs/core/src/components/pds-accordion/pds-accordion.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { downSmall } from '@pine-ds/icons/icons';
/**
* @part accordion-body - Accordion body styles.
* @part accordion-button - Accordion button/trigger styles.
* @part accordion-icon - Accordion icon styles.
* @slot (default) - Accordion body content.
* @slot label - Accordion trigger button content.
*/
Expand Down Expand Up @@ -57,7 +58,7 @@ export class PdsAccordion {
<details {...this.getOpenAttribute()} ref={(el) => (this.detailsEl = el as HTMLDetailsElement)}>
<summary part="accordion-button">
<slot name="label">Details</slot>
<pds-icon icon={downSmall} />
<pds-icon icon={downSmall} part="accordion-icon" />
</summary>
<div part="accordion-body" class="pds-accordion__body">
<slot />
Expand Down
1 change: 1 addition & 0 deletions libs/core/src/components/pds-accordion/readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
| -------------------- | -------------------------------- |
| `"accordion-body"` | Accordion body styles. |
| `"accordion-button"` | Accordion button/trigger styles. |
| `"accordion-icon"` | Accordion icon styles. |


## Dependencies
Expand Down
12 changes: 6 additions & 6 deletions libs/core/src/components/pds-accordion/test/pds-accordion.spec.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ describe('pds-accordion', () => {
<details>
<summary part="accordion-button">
<slot name="label">Details</slot>
<pds-icon icon="${downSmall}"></pds-icon>
<pds-icon icon="${downSmall}" part="accordion-icon"></pds-icon>
</summary>
<div part="accordion-body" class="pds-accordion__body">
<slot />
Expand All @@ -36,7 +36,7 @@ describe('pds-accordion', () => {
<details open>
<summary part="accordion-button">
<slot name="label">Details</slot>
<pds-icon icon="${downSmall}"></pds-icon>
<pds-icon icon="${downSmall}" part="accordion-icon"></pds-icon>
</summary>
<div part="accordion-body" class="pds-accordion__body">
<slot />
Expand All @@ -59,7 +59,7 @@ describe('pds-accordion', () => {
<details>
<summary part="accordion-button">
<slot name="label">Details</slot>
<pds-icon icon="${downSmall}"></pds-icon>
<pds-icon icon="${downSmall}" part="accordion-icon"></pds-icon>
</summary>
<div part="accordion-body" class="pds-accordion__body">
<slot />
Expand All @@ -82,7 +82,7 @@ describe('pds-accordion', () => {
<details>
<summary part="accordion-button">
<slot name="label">Details</slot>
<pds-icon icon="${downSmall}"></pds-icon>
<pds-icon icon="${downSmall}" part="accordion-icon"></pds-icon>
</summary>
<div part="accordion-body" class="pds-accordion__body">
<slot />
Expand All @@ -106,7 +106,7 @@ describe('pds-accordion', () => {
<details>
<summary part="accordion-button">
<slot name="label">Details</slot>
<pds-icon icon="${downSmall}"></pds-icon>
<pds-icon icon="${downSmall}" part="accordion-icon"></pds-icon>
</summary>
<div part="accordion-body" class="pds-accordion__body">
<slot />
Expand All @@ -130,7 +130,7 @@ describe('pds-accordion', () => {
<details open>
<summary part="accordion-button">
<slot name="label">Details</slot>
<pds-icon icon="${downSmall}"></pds-icon>
<pds-icon icon="${downSmall}" part="accordion-icon"></pds-icon>
</summary>
<div part="accordion-body" class="pds-accordion__body">
<slot />
Expand Down
Loading