Skip to content

Conversation

@QuintonJason
Copy link
Contributor

Description

  • update examples to use sizes with modifiers

Fixes N/A

Type of change

  • This change requires a documentation update

How Has This Been Tested?

  • unit tests
  • e2e tests
  • accessibility tests
  • tested manually
  • other:

Test Configuration:

  • Pine versions:
  • OS:
  • Browsers:
  • Screen readers:
  • Misc:

Checklist:

If not applicable, leave options unchecked.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@netlify
Copy link

netlify bot commented Oct 22, 2025

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit 76b4676
🔍 Latest deploy log https://app.netlify.com/projects/pine-design-system/deploys/68f8fe6a4fea4a000860485b
😎 Deploy Preview https://deploy-preview-566--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added documentation Improvements or additions to documentation package: core Changes have been made to the Core package labels Oct 22, 2025
@QuintonJason QuintonJason marked this pull request as ready for review October 22, 2025 17:57
@QuintonJason QuintonJason self-assigned this Oct 22, 2025
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is being reviewed by Cursor Bugbot

Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

<pds-box size="6"><pds-box border>Column A</pds-box></pds-box>
<pds-box size="6"><pds-box border>Column B</pds-box></pds-box>
<pds-box size-md="6"><pds-box border>Column A</pds-box></pds-box>
<pds-box size-md="6"><pds-box border>Column B</pds-box></pds-box>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Gap Examples Misaligned on Small Screens

The PdsRow gap examples now use size-md props, causing column layouts to change on small screens. This makes the gap demonstrations inconsistent and confusing, as the examples are intended to focus on gap functionality, not responsive behavior.

Fix in Cursor Fix in Web

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine. I want the example to be mobile-first in all cases where size is used

Copy link
Member

@pixelflips pixelflips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@QuintonJason QuintonJason merged commit e1b7564 into main Oct 22, 2025
34 of 37 checks passed
@QuintonJason QuintonJason deleted the docs/row-update-size-refs branch October 22, 2025 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation package: core Changes have been made to the Core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants