Skip to content

Conversation

@pixelflips
Copy link
Member

@pixelflips pixelflips commented Oct 21, 2025

Description

This PR enables CSS gradient support for the pds-progress component's fill color by changing the background-color property to background in the progress bar styling.

Previously, users could not use gradients (e.g., linear-gradient(), radial-gradient()) with the fillColor prop or --color-progress-fill CSS variable because background-color only accepts solid color values. This change maintains backward compatibility with solid colors while unlocking support for gradients and other advanced background properties.

Fixes: https://kajabi.atlassian.net/browse/DSS-1560

Changes Made

  • Updated pds-progress.scss to use background instead of background-color for WebKit and Mozilla progress bar pseudo-elements
  • Added documentation example demonstrating gradient usage with Pine color tokens
Screenshot
Screenshot 2025-10-21 at 2 07 35 PM

Type of change

  • Style fix (non-breaking change which fixes an issue)
  • This change requires a documentation update

How Has This Been Tested?

  • tested manually - Verified gradient rendering in progress component
  • Tested solid color compatibility to ensure no regression
  • Validated documentation example displays correctly

Test Configuration:

  • Pine versions:
  • OS:
  • Browsers:
  • Screen readers:
  • Misc:

Checklist:

If not applicable, leave options unchecked.

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • Design has QA'ed and approved this PR

@pixelflips pixelflips self-assigned this Oct 21, 2025
@netlify
Copy link

netlify bot commented Oct 21, 2025

Deploy Preview for pine-design-system ready!

Name Link
🔨 Latest commit e708eec
🔍 Latest deploy log https://app.netlify.com/projects/pine-design-system/deploys/68f7f6af92481b00088642ad
😎 Deploy Preview https://deploy-preview-564--pine-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions github-actions bot added the package: core Changes have been made to the Core package label Oct 21, 2025
@pixelflips pixelflips marked this pull request as ready for review October 21, 2025 21:10
Copy link
Contributor

@QuintonJason QuintonJason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

@pixelflips pixelflips merged commit bcc76d1 into main Oct 22, 2025
19 checks passed
@pixelflips pixelflips deleted the style/progress-gradient branch October 22, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

package: core Changes have been made to the Core package

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants