-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add contained variant to pds-radio component #478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Add variant prop with 'default' and 'contained' options - Add icon prop for contained variant icon display - Update styling for contained variant with proper states - Add comprehensive Storybook stories for all contained variant states - Add unit tests covering variant and icon functionality - Update documentation with contained variant examples - Maintain full radio functionality across all variants DSS-1473 Co-Authored-By: Quinton Jason Jr <quinton.jason@kajabi.com>
Contributor
|
Original prompt from Quinton: |
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
✅ Deploy Preview for pine-design-system ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Author
|
Close in favor of #562 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add contained variant to pds-radio component
Summary
This PR adds a new "contained" variant to the pds-radio component that replaces the standard radio circle with an icon while maintaining all radio functionality. The implementation includes:
variant('default' | 'contained') andicon(string)The contained variant follows the established Pine Design System patterns and maintains full accessibility and functionality.
Jira Ticket: DSS-1473
Review & Testing Checklist for Human
Risk Level: 🟡 Medium - Visual changes with accessibility implications
:has()selectors) works consistently across supported browsersRecommended Test Plan:
Diagram
%%{ init : { "theme" : "default" }}%% graph TD A["pds-radio.tsx<br/>Component Implementation"]:::major-edit B["pds-radio.scss<br/>Styling"]:::major-edit C["pds-radio.stories.js<br/>Storybook Stories"]:::major-edit D["pds-radio.spec.tsx<br/>Unit Tests"]:::major-edit E["pds-radio.mdx<br/>Documentation"]:::major-edit F["components.d.ts<br/>Auto-generated Types"]:::minor-edit G["readme.md<br/>Auto-generated Docs"]:::minor-edit H["pds-icon<br/>Icon Component"]:::context A --> H A --> B B --> C C --> D A --> F A --> G E --> C subgraph Legend L1[Major Edit]:::major-edit L2[Minor Edit]:::minor-edit L3[Context/No Edit]:::context end classDef major-edit fill:#90EE90 classDef minor-edit fill:#87CEEB classDef context fill:#FFFFFFNotes
:has()selectors for state styling - verify browser support meets requirementspds-iconcomponent working correctlySession Info: