Add front-end support for roster additions #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lnjX
reviewed
Mar 5, 2017
src/qml/AddContactPage.qml
Outdated
| import QtQuick.Layouts 1.2 | ||
| import org.kde.kirigami 1.0 as Kirigami | ||
|
|
||
| Kirigami.Page { |
There was a problem hiding this comment.
Don't use a new page! It's just a popup.
There was a problem hiding this comment.
I don't want to use the popup anymore, it produces problems with the drawer, is not the best on mobile and has to be centered in the middle of the window. The page looks not so great on desktop yet...
lnjX
reviewed
Mar 5, 2017
src/qml/RosterPage.qml
Outdated
| Kirigami.Action { | ||
| iconName: "bookmark-remove" | ||
| onTriggered: { | ||
| kaidan.rosterController.removeContact(model.jid) |
|
... no labels 👎 |
lnjX
force-pushed
the
rosterediting
branch
2 times, most recently
from
0e7189b to
b91e7f9
Compare
lnjX
changed the title
lnjX
changed the title
lnjX
approved these changes
Apr 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's working already ... although I'm not satisfied with the desgin. Some things can't be fixed because the same bug as on the loginPage appeared. I would like to rework this soon on a kirigami 2 base.