Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Travis CI integration #133

Merged
merged 11 commits into from
Nov 19, 2017
Merged

Travis CI integration #133

merged 11 commits into from
Nov 19, 2017

Conversation

jbruechert
Copy link
Member

This may look a little bit ugly, because all relevant commands are in one line, but to be honest I have no plan of travis and this works fine so far.

I found a nice upload tool here, but I haven't integrated it yet. So all the builds made are just for testing if it builds, not for release.

btw: Please squash my commit mess, you know testing travis ci ... needs a few until it works.

Copy link
Member

@lnjX lnjX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you send a link to your test travis-job? :)

.travis.yml Outdated
@@ -0,0 +1,12 @@
sudo: required

language: ruby
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem correct

.travis.yml Outdated
- docker

before_install:
- docker pull debian:sid-slim
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space is missing at the beginning of the line

.travis.yml Outdated
- docker pull debian:sid-slim

script:
- docker run -v $PWD:/mnt/kaidan debian:sid-slim /bin/bash -c "apt update; apt install software-properties-common dirmngr gnupg ca-certificates git -y; apt-key adv --keyserver hkp://pgp.mit.edu --recv-key "210EB0BCA70439F0"; echo deb https://raw.githubusercontent.com/kaidanim/packages/master sid main >> /etc/apt/sources.list; apt-get update; apt-get install cmake build-essential zlib1g-dev libgloox-dev libqt5quick5 libqt5quickcontrols2-5 libqt5quickwidgets5 libqt5qml5 libqt5gui5 libqt5core5a qtdeclarative5-dev qttools5-dev qt5-default qtquickcontrols2-5-dev kirigami2-dev -y; cd /mnt/kaidan; mkdir build; cd build; cmake .. -DI18N=1; make -j$(nproc)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A space is missing at the beginning of the line.
Please separate every command into a new line (starting with -).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively, you can also create a shell script and just execute that.

Copy link
Member Author

@jbruechert jbruechert Nov 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please separate every command into a new line (starting with -).

It's only one (bash -c)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then maybe something like bash -c $(cat util/travis.sh)?

@lnjX
Copy link
Member

lnjX commented Nov 19, 2017

So all the builds made are just for testing if it builds, not for release.

That's what travis is for, not for really releasing builds.

@jbruechert
Copy link
Member Author

@lnjX
Copy link
Member

lnjX commented Nov 19, 2017

Could you (optionally) move the dependency installation into before-install, instead of script? Then travis-ci would hide it in the log first / you have to unfold it first.

@jbruechert
Copy link
Member Author

Docker seems to reset the container each time before a new command is run inside. You can probably change that, but I don't know how.

@lnjX lnjX merged commit 847ec8c into KaidanIM:master Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants