Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RosterPage: New design, Add fallback avatar #118

Merged
merged 1 commit into from
Aug 4, 2017
Merged

RosterPage: New design, Add fallback avatar #118

merged 1 commit into from
Aug 4, 2017

Conversation

lnjX
Copy link
Member

@lnjX lnjX commented Aug 3, 2017

No description provided.

@lnjX lnjX changed the title New roster design [WIP] New roster design Aug 3, 2017
@lnjX lnjX force-pushed the new-roster-design branch from f010784 to 5926679 Compare August 3, 2017 20:22
@lnjX lnjX changed the title [WIP] New roster design RosterPage: New design, Add fallback avatar Aug 3, 2017
@lnjX lnjX added this to the 0.3 milestone Aug 3, 2017
@lnjX lnjX force-pushed the new-roster-design branch from 5926679 to 8645b68 Compare August 3, 2017 20:30
RosterPage: New design, Add fallback avatar
b80ca57 
The new roster page displays the last message with the contact.
@lnjX lnjX force-pushed the new-roster-design branch from 8645b68 to b80ca57 Compare August 4, 2017 09:00
jbruechert
jbruechert approved these changes Aug 4, 2017
View reviewed changes
Copy link
Member

@jbruechert jbruechert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
The only thing is that the elements folder, and the "kaidan.removeNewLinesFromString()" function should be moved to a new IMComponents library for sharing code with Ruquola. However that is not a blocker and can be done later, so this can be merged.

@lnjX
Copy link
Member Author

lnjX commented Aug 4, 2017

@jbbgameich Well it must be later, because we currently don't have such library and adding this library would be out of scope of the PR.

@jbruechert jbruechert merged commit 1a951c1 into KaidanIM:master Aug 4, 2017
@lnjX lnjX deleted the new-roster-design branch August 4, 2017 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbruechert jbruechert jbruechert approved these changes

Assignees
No one assigned
Labels
roster / contacts user interface
Projects
None yet
Milestone
0.3
Development

Successfully merging this pull request may close these issues.
2 participants
@lnjX @jbruechert