Switch to XMPP library gloox #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
lnjX
commented
Jun 19, 2017
•
lnjX
commented
- Add CMake dependency
- Add gloox client in the Kaidan class
- Rewrite MessageController
- Rewrite RosterController
- Rewrite PresenceController (including software version / entity identity)
- Rewrite Kaidan class
- Rewrite everything else
- Remove Swift Client
- Remove Swift/Boost dependencies
- Update dependencies in the README
- Update QML API documentation
- Add Logger for incoming/outgoing XML
- Add Delayed Delivery (messages with timestamp)
|
This will be merged using rebase/fast-forward and the commit history in here will be kept. |
|
Now also Message Delivery Receipts work again! :) |
|
Now we have nearly everything in gloox again. :) |
|
Does anyone want to try out if compiling Kaidan still works with the new dependencies (and the gloox rewrite). Before I push this to master ... |
added 12 commits
July 29, 2017 20:12
Rewrote the MessageController into a MessageSessionHandler and a MessageHandler. It still supports everything as before (e.g. Message Receipts).
The Sub/Unsub management in gloox is done in the Roster/RosterListener/RosterUpdater. Therefore the PresenceHandler is currently useless. (Probably will change in the future) Sub requests are accepted automatically and the user will be unsubbed on incoming unsub requests (when the other entity unsubs from the user).
This rewrites the service discovery manager using gloox. XMPP Ping and Software Version are automatically anounced by gloox.
These classes need to be revised (besides the gloox rewrite). They are currently not used anyway. The gloox rewrite can be finished before these classes are redone.
This new XmlLogHandler will print all incoming and outgoing XML in a pretty format onto the console. It's using the QXml module.
It covers both implementations: XEP-0091 (deprecated) and the new XEP-0203.
Now the QML API documentation is up to date again with the gloox rewrite.
Updated all dependecies and the description.
|
I tried to compile Kaidan in a chroot with the new dependencies in the README - It works. :) |
The management of the lastMessage and the unreadMessageCount for each contact are now located in the MessageHandler. This fixes that these functions were not called and the features were not usable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.