[WIP] Create runtime gRPC proto definition #64
Conversation
kchrist-rocketfueldev
force-pushed
the
runtime-grpc-proto-definition
branch
from
00e90f2
to
0c4c231
Compare
There was a problem hiding this comment.
Also @kchrist-rocketfueldev can we get some more comments in there as seen in https://protobuf.dev/programming-guides/proto3/#adding-comments?
common/types/src/runtime.proto
Outdated
| } | ||
|
|
||
| /* getName */ | ||
| message GetNameRequest { |
There was a problem hiding this comment.
Can we be more explicit on what GetNameRequest is? Which name does it request?
There was a problem hiding this comment.
would getRuntimeName make more sense?
common/types/src/runtime.proto
Outdated
| } | ||
|
|
||
| /* getVersion */ | ||
| message GetVersionRequest { |
There was a problem hiding this comment.
Same here, what version are we requesting and of what?
common/types/src/runtime.proto
Outdated
| @@ -0,0 +1,118 @@ | |||
| syntax = "proto3"; | |||
|
|
|||
| package kyve.tendermint; | |||
There was a problem hiding this comment.
Are you thinking of creating one .proto file for every runtime parent class? Meaning all the EVM runtimes will use X .proto as a source, all Cosmos runtime will use Y as a source?
Is it possible to create just a single .proto file for all runtimes?
There was a problem hiding this comment.
it should not be here, it was a leftover from when i did multiple implementations to compare them
kchrist-rocketfueldev
changed the title
| @@ -52,6 +52,24 @@ import { SupportedChains } from "@kyvejs/sdk/dist/constants"; | |||
| import { storageProviderFactory } from "./reactors/storageProviders"; | |||
| import { compressionFactory } from "./reactors/compression"; | |||
| import { cacheProviderFactory } from "./reactors/cacheProvider"; | |||
| const grpc = require("@grpc/grpc-js"); | |||
| var protoLoader = require("@grpc/proto-loader"); | |||
| const PROTO_PATH = "./runtiime.proto"; | |||
No description provided.