-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Create runtime gRPC proto definition #64
Conversation
00e90f2
to
0c4c231
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also @kchrist-rocketfueldev can we get some more comments in there as seen in https://protobuf.dev/programming-guides/proto3/#adding-comments?
common/types/src/runtime.proto
Outdated
} | ||
|
||
/* getName */ | ||
message GetNameRequest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we be more explicit on what GetNameRequest
is? Which name does it request?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would getRuntimeName
make more sense?
common/types/src/runtime.proto
Outdated
} | ||
|
||
/* getVersion */ | ||
message GetVersionRequest { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here, what version are we requesting and of what?
common/types/src/runtime.proto
Outdated
@@ -0,0 +1,118 @@ | |||
syntax = "proto3"; | |||
|
|||
package kyve.tendermint; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you thinking of creating one .proto
file for every runtime parent class? Meaning all the EVM runtimes will use X .proto
as a source, all Cosmos runtime will use Y
as a source?
Is it possible to create just a single .proto
file for all runtimes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it should not be here, it was a leftover from when i did multiple implementations to compare them
@@ -52,6 +52,24 @@ import { SupportedChains } from "@kyvejs/sdk/dist/constants"; | |||
import { storageProviderFactory } from "./reactors/storageProviders"; | |||
import { compressionFactory } from "./reactors/compression"; | |||
import { cacheProviderFactory } from "./reactors/cacheProvider"; | |||
const grpc = require("@grpc/grpc-js"); | |||
var protoLoader = require("@grpc/proto-loader"); | |||
const PROTO_PATH = "./runtiime.proto"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: runtiime -> runtime
No description provided.