Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: avoid downstream dependency runtime errors #154

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

fedellen
Copy link
Contributor

hey there! we're running into some runtime errors when integrating @kyvejs/sdk into some of our software:

Error: @kyvejs/types tried to access long, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: long
Required by: @kyvejs/types@npm:1.4.0 (via /Users/derek/ar-io/ardrive-cli/.yarn/cache/@kyvejs-types-npm-1.4.0-fab6e0745a-fe33d33dc0.zip/node_modules/@kyvejs/types/client/cosmos/gov/v1/)

Require stack:
- /Users/derek/ar-io/ardrive-cli/.yarn/cache/@kyvejs-types-npm-1.4.0-fab6e0745a-fe33d33dc0.zip/node_modules/@kyvejs/types/client/cosmos/gov/v1/tx.js


Error: @kyvejs/sdk tried to access @cosmjs/math, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: @cosmjs/math
Required by: @kyvejs/sdk@npm:1.3.2 (via /Users/derek/ar-io/ardrive-cli/.yarn/cache/@kyvejs-sdk-npm-1.3.2-8e96208daf-38c4edce14.zip/node_modules/@kyvejs/sdk/dist/amino/)

Require stack:
- /Users/derek/ar-io/ardrive-cli/.yarn/cache/@kyvejs-sdk-npm-1.3.2-8e96208daf-38c4edce14.zip/node_modules/@kyvejs/sdk/dist/amino/stakers.amino.js
- /Users/derek/ar-io/ardrive-cli/.yarn/cache/@kyvejs-sdk-npm-1.3.2-8e96208daf-38c4edce14.zip/node_modules/@kyvejs/sdk/dist/amino/index.js
- /Users/derek/ar-io/ardrive-cli/.yarn/cache/@kyvejs-sdk-npm-1.3.2-8e96208daf-38c4edce14.zip/node_modules/@kyvejs/sdk/dist/clients/full-client.js

            ^

Error: @kyvejs/types tried to access protobufjs, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: protobufjs (via "protobufjs/minimal")
Required by: @kyvejs/types@npm:1.4.0 (via /Users/derek/ar-io/ardrive-cli/.yarn/cache/@kyvejs-types-npm-1.4.0-fab6e0745a-fe33d33dc0.zip/node_modules/@kyvejs/types/client/cosmos/gov/v1/)

Require stack:
- /Users/derek/ar-io/ardrive-cli/.yarn/cache/@kyvejs-types-npm-1.4.0-fab6e0745a-fe33d33dc0.zip/node_modules/@kyvejs/types/client/cosmos/gov/v1/tx.js

          ^

Error: @kyvejs/sdk tried to access cosmjs-types, but it isn't declared in its dependencies; this makes the require call ambiguous and unsound.

Required package: cosmjs-types (via "cosmjs-types/cosmos/tx/v1beta1/tx")
Required by: @kyvejs/sdk@npm:1.3.2 (via /Users/derek/ar-io/ardrive-cli/.yarn/cache/@kyvejs-sdk-npm-1.3.2-8e96208daf-38c4edce14.zip/node_modules/@kyvejs/sdk/dist/clients/rpc-client/)

Require stack:
- /Users/derek/ar-io/ardrive-cli/.yarn/cache/@kyvejs-sdk-npm-1.3.2-8e96208daf-38c4edce14.zip/node_modules/@kyvejs/sdk/dist/clients/rpc-client/signing.js

providing these dependencies in the PR does avoid these errors, but it will be better to have KYVE SDK providing them

@troykessler troykessler self-requested a review September 12, 2024 06:37
@troykessler troykessler merged commit 87aadf0 into KYVENetwork:main Sep 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants