chore: prepare v1.5 #206
chore: prepare v1.5 #206
Conversation
WalkthroughIn version Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant App
participant IAVL
User->>App: Interact with blockchain events
App->>IAVL: Use new IAVL version
IAVL-->>App: Return data without pruning errors
App-->>User: Receive correct responses for events
User->>App: Request legacy RPC block results
App->>App: Fetch correct legacy block results
App-->>User: Return accurate results
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range and nitpick comments (1)
app/upgrades/v1_5/upgrade.go (1)
211-212: Remove the TODO comment.The TODO comment indicating that prices were obtained on
03.07.2024should be removed or converted into a proper comment.- // Prices were obtained on 03.07.2024 + // Prices for the coins were obtained on 03.07.2024
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (4)
- CHANGELOG.md (3 hunks)
- CONTRIBUTING.md (1 hunks)
- Makefile (1 hunks)
- app/upgrades/v1_5/upgrade.go (2 hunks)
Files skipped from review due to trivial changes (2)
- CONTRIBUTING.md
- Makefile
Additional comments not posted (6)
CHANGELOG.md (3)
17-17: Ensure the release date is accurate.The release date for version
v1.5.0is set to2024-07-05. Verify that this date is correct.
32-32: Review event naming alignment.The improvement to align event naming is mentioned in the changelog. Ensure that all events in the codebase follow the new naming conventions.
Verification successful
Verification of Event Naming Alignment
The event names in the codebase generally follow the pattern
Event<Verb><Noun>. Here are the event names found:
EventCreateTeamVestingAccountEventClawbackEventClaimedUnlockedEventClaimInflationRewardsEventClaimAuthorityRewardsEventUpdateParamsEventCreatePoolEventPoolEnabledEventPoolDisabledEventRuntimeUpgradeScheduledEventRuntimeUpgradeCancelledEventPoolUpdatedEventPoolFundsSlashedEventCreateStakerEventUpdateMetadataEventUpdateCommissionEventClaimCommissionRewardsEventJoinPoolEventLeavePoolEventDefundPoolEventFundPoolEventPoolOutOfFundsEventDelegateEventStartUndelegationEventUndelegateEventRedelegateEventWithdrawRewardsEventSlashEventPointsResetEventPointIncreasedEventBundleProposedEventBundleVoteEventBundleFinalizedEventClaimedUploaderRoleEventSkippedUploaderRoleAll these event names adhere to the pattern
Event<Verb><Noun>, indicating that the event naming conventions are consistent with the new alignment.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify that all events follow the new naming conventions. # Test: Search for event names. Expect: Consistent naming conventions. rg --type go 'Event'Length of output: 181683
45-46: Verify the bug fixes.The bug fixes for using the newest IAVL version to prevent pruning errors and returning correct results for legacy RPC block_results requests are mentioned. Ensure these fixes are correctly implemented and tested.
app/upgrades/v1_5/upgrade.go (3)
213-220: Ensure the accuracy of KYVE coin details.The details for KYVE coin, including
CoinWeightupdated from0.06to0.0358, should be verified for accuracy.
221-228: Ensure the accuracy of Andromeda coin details.The details for Andromeda coin, including
CoinWeightset to0.1007, should be verified for accuracy.
229-235: Ensure the accuracy of Source Protocol coin details.The details for Source Protocol coin, including
CoinWeightset to0.0207, should be verified for accuracy.
Summary by CodeRabbit
New Features
Improvements
Bug Fixes
block_resultsrequests.Chores
CONTRIBUTING.md.BUILD_TIMEvariable inMakefilefor accurate build tracking.Enhancements
CoinWhitelistinitialization for KYVE, Andromeda, and Source Protocol with refined coin details and weights.