Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Landmarking improvements #53

Merged
merged 6 commits into from
Mar 15, 2020
Merged

Landmarking improvements #53

merged 6 commits into from
Mar 15, 2020

Conversation

hkjeldsberg
Copy link
Collaborator

@hkjeldsberg hkjeldsberg commented Jan 17, 2020 •
edited
Loading

  • Improve search for max coronal coordinate
  • Search both max and min when finding max coronal coordinate
  • Rename angle to 'theta'
  • Reduce initial gaussian filter smoothing
  • Add reverse centerline method + Test
  • Reverse centerline if path of centerline is in distal direction.
  • Added input parameter for Bogunovic-algorithm: coronal_axis to determine coronal coordinate.

hkjeldsberg and others added 3 commits November 28, 2019 13:48
@hkjeldsberg
Check coronal max location
6925a0c
@hkjeldsberg
Improve search for max coronal coordinate.
16e5464 
- Search both max and min when finding max coronal coordinate
- Rename angle to 'theta'
- Reduce initial gaussian filter smoothing
@hkjeldsberg
Removed checking of coronal distance file
2be6aef
aslakbergersen
aslakbergersen requested changes Jan 17, 2020
View reviewed changes
Copy link
Collaborator

@aslakbergersen aslakbergersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had one comment, but it looks good if all the tests pass.

morphman/common/centerline_operations.py Show resolved Hide resolved
@hkjeldsberg
Reimplemented reverse centerline + added test
d992aba 
- Added method checking for axial coordinate
- Added option for user to input coronal coordinate, used in Bogunovic-algorithm.
@hkjeldsberg
Reordered methods
0193f07
@hkjeldsberg
Remvoed IPython import
df6c663
@hkjeldsberg hkjeldsberg merged commit acab448 into master Mar 15, 2020
@hkjeldsberg hkjeldsberg deleted the landmarking-improvements branch March 15, 2020 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aslakbergersen aslakbergersen aslakbergersen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hkjeldsberg @aslakbergersen