Make Completion and Run APIs consistent

[bekelley]

Currently the EpicImporters modues' _completions function assumes the words array to contain the entire commandline - including the command itself (i.e ['command1', 'subcmd1' ... ])

However, the modules' _run function expects the argv parameter to be just the arguments - excluding the command itself (i.e. ['subcmd1' ... ]

The APIs between the two functions should more be consistent, at least in regards to argv/words expectation

[nkakouros]

Since both _completions and _run lie in the importer class, I think it makes sense for them to receive only the command arguments and their options/args. For example, if the user runs on the cli:

twmn cmd1 arg1 --option1

then, these functions should receive just cmd1 arg1 --option1. The first argv (twmn) is not of interest to the importer at all; the importer cares about commands it needs to resolve and the args that are passed to them (for completion purposes).

[bekelley]

In your example is twmn an EpicRunner? Like the twmn.py script that's currently in the repo?

If so, then in the current state of the code this is stripped off already before it gets to the _completions and _run functions.

In your example, the current code for _completions expects ['cmd1', 'arg1', '--option1'] and _run expects ['arg1', '--option1']

[nkakouros]

I see. In this case, why not have _completions accept ['arg1', '--option1'] as well?

[bekelley]

I was thinking that's probably the best option as well