Implemented marquee text for album titles, descriptions and artist names #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…static text for those with short ones
…s to the marquee effect in the PlayButtonCard as well
… and also used it for the PlayButtonCards in the Browse page
|
That is awesome. Everything seems to work fine & the Album/Playlist cards look amazing |
Closed
Awesome! Glad to hear you like it as well 🥳 I'll post an issue regarding the user playlist image size next and see if I can fix that 🎉 |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request solves issue #15 by implementing automatically scrollable (marquee) text for the album titles, descriptions and artist names. The marquee text is used only when the text exceeds a certain threshold of character length, otherwise a static Text widget is used instead to create a pleasant UI/UX. The changes can be easily observed in the "Browse", "Playlists", "Album" or any other relevant page where a long album name/description or artist name is present.