Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add iOS and macOS support #3

Merged
merged 2 commits into from
Sep 23, 2022
Merged

Conversation

mouEsam
Copy link
Contributor

@mouEsam mouEsam commented Sep 22, 2022

This PR adds support for macOS and iOS.

Closes #1

@KRTirtho
Copy link
Owner

Does the example app runs perfectly fine one macOS? (with actual audio file path) 😃

@mouEsam
Copy link
Contributor Author

mouEsam commented Sep 22, 2022

The example runs and loads the library fine. I’ll test an actual audio file and post the result.

@KRTirtho
Copy link
Owner

Thanks man. You're awesome

@mouEsam
Copy link
Contributor Author

mouEsam commented Sep 22, 2022

Confirmed!
The library works fine.
You can merge safely.

@KRTirtho KRTirtho merged commit a648e47 into KRTirtho:main Sep 23, 2022
@KRTirtho
Copy link
Owner

Hey looks like macos version is not working and the example app throwing following error
image

@KRTirtho
Copy link
Owner

Looks like macos/Frameworks/rust_crate.framework/Versions/A/rust_crate is a static reference so it won't work anywhere except your own macOS instance 😅 . Can't we directly put the librust.dylib in macos/Frameworks/rust_crate.framework/Versions/A renaming to rust_crate?

@mouEsam
Copy link
Contributor Author

mouEsam commented Sep 26, 2022

Looks like the issue is with the symbolic link in the framework. I’ll look into it.

@karniv00l karniv00l mentioned this pull request Sep 27, 2022
@shadow5688
Copy link

@mouEsam can #26 be looked into please?

@mouEsam
Copy link
Contributor Author

mouEsam commented Dec 3, 2023

@mouEsam can #26 be looked into please?

Gladly tomorrow 👍

@shadow5688
Copy link

Gladly tomorrow 👍

Hey @mouEsam, Were you able to look into it? If there's something needed from my end, then lemme know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iOS support
3 participants