Skip to content

Introduced class AnimCallNode and increased readability in typecheckv… #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
FredTheNoob merged 2 commits into from
Jun 22, 2023
Merged

Introduced class AnimCallNode and increased readability in typecheckv… #62

FredTheNoob merged 2 commits into from
Jun 22, 2023

Conversation

@AsbjoernJC
Copy link
Collaborator

@AsbjoernJC AsbjoernJC commented Jun 22, 2023

  • Introduced new abstract class AnimCallNode
  • Improved readability in typecheckvisitor
  • Refactored typechecking of arguments in nodes that inherit from AnimCallNode
  • Created function that typechecks arguments
  • Created function that typechecks idNodes

FredTheNoob
FredTheNoob approved these changes Jun 22, 2023
View reviewed changes
Copy link
Collaborator

@FredTheNoob FredTheNoob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sehr gut!

@FredTheNoob FredTheNoob merged commit 7e126c2 into main Jun 22, 2023
@FredTheNoob FredTheNoob deleted the typecheckreadability branch June 22, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@FredTheNoob FredTheNoob FredTheNoob approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@AsbjoernJC @FredTheNoob