Skip to content

Conversation

@damianborowy
Copy link
Collaborator

No description provided.

@KMoszczyc
Copy link
Owner

KMoszczyc commented Jan 4, 2026

image that's how example of failed bet looks like, I think it should show how much credits actually someone lost/got due to the random event.

And.. this is RandomSuccessEvent, where it should be RandomFailureEvent in this case lol.

@KMoszczyc
Copy link
Owner

Also I'd remove the entire CriticalRoll class as imo its completely redundant and can be replaced with:

CRITICAL_FAILURE_CHANCE = 0.05
CRITICAL_SUCCESS_CHANCE = 0.05

in definitions.py

and

def roll(probability):
    """Roll a probability dice and return True if the hit is successful. The range of random() is [0, 1], so.. yeah it works."""
    return random.random() < probability

in src.core.utils.py

  • more reusable, readable, smarter etc etc... when mf thinks that he can vibe code python lol

@KMoszczyc
Copy link
Owner

KMoszczyc commented Jan 5, 2026

And also dont forget alt+ctrl+shift+l for code formatting! so there are entersat the bottom of the file etc etc

@KMoszczyc KMoszczyc merged commit fe242f7 into main Jan 5, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants