Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add domain seperator in bunch signatures as per EIP 191 #9

Open
zemse opened this issue May 24, 2020 · 1 comment
Open

Add domain seperator in bunch signatures as per EIP 191 #9

zemse opened this issue May 24, 2020 · 1 comment
Labels
bug Something isn't working documentation Improvements or additions to documentation needs thinking Extra planning is needed

Comments

@zemse
Copy link
Contributor

zemse commented May 24, 2020 •
edited
Loading

also need to implement this in the smart contract
@zemse zemse added bug Something isn't working needs thinking Extra planning is needed labels May 24, 2020
@zemse
Copy link
Contributor Author

zemse commented May 24, 2020

add chainId and purpose in the existing domain seperator object. rename it to Era Swap Network. Also mention it in technical specification.

@zemse zemse added the documentation Improvements or additions to documentation label May 24, 2020
zemse added a commit to zemse/kami that referenced this issue May 28, 2020
@zemse
remove the domain seperator for a while KMPARDS#9
61b413f
zemse added a commit that referenced this issue May 28, 2020
@zemse
Add Informer toETH module's initiateBunch method (#23)
c398840 
* add contracts

* update tests

* add initiate bunch

* remove the domain seperator for a while #9

* add test case validation for submit bunch

* fix provider reference bug

* temp patch ethers issue #24

* fix naming and add todo
zemse added a commit to zemse/kami that referenced this issue Jun 2, 2020
@zemse
work on EIP-191 domain seperators KMPARDS#9
678bade
zemse added a commit that referenced this issue Jun 2, 2020
@zemse
work on EIP-191 domain seperators #9
84a8baf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation Improvements or additions to documentation needs thinking Extra planning is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zemse