Fix digitalio matrix orientation #927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xs5871
approved these changes
Jan 8, 2024
Set `pull` to former default
hixan
pushed a commit
to hixan/kmk_firmware
that referenced
this pull request
Feb 21, 2024
Fixed digitalio matrix orientation, changed `pull` default to better match target hardware, changed keyboard_test to former default
hixan
pushed a commit
to hixan/kmk_firmware
that referenced
this pull request
Nov 4, 2024
Fixed digitalio matrix orientation, changed `pull` default to better match target hardware, changed keyboard_test to former default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the bug I introduced earlier. Not especially pretty, but this scanner's code is very hard to follow in general.