Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks to the example in the Display extension doc #926

Merged
merged 2 commits into from
Jan 4, 2024

Conversation

brianmarco
Copy link
Contributor

A few tweaks to the example mentioned in the Display extension documentation.

Copy link
Collaborator

@xs5871 xs5871 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One thing: the device_address value is the same as the default. I think we should clarify that, i.e. comment it out as optional and add that 0x3C is the default and only needs to be changed if necessary -- just to avoid confusion and duplicate code proliferation.

@brianmarco
Copy link
Contributor Author

Thanks for the review @xs5871 . I applied your feedback as suggested. I also applied the same feedback to the width argument for Display, and adjusted the dim_target argument to make it different from the default.

Copy link
Collaborator

@xs5871 xs5871 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks.

@xs5871 xs5871 merged commit d821f36 into KMKfw:master Jan 4, 2024
1 check passed
hixan pushed a commit to hixan/kmk_firmware that referenced this pull request Feb 21, 2024
hixan pushed a commit to hixan/kmk_firmware that referenced this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants