-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🧩 Feature: Document husky usage on main README #39
Comments
It already runs a pre-commit hook on my machine, doesn't it on yours? |
The configuration is setup in package.json to lint commit messages before they're admitted, and if the linting process returns errors it'll stop the whole commit. ESLint, Prettier, and Jest are set to run on |
"prepare-commit-msg": "exec < /dev/tty && git cz --hook || true" runs commitizen on |
The And I just remembered that in the committing section of the contribution guide it's mentioned that this is left out by choice.
I don't wish to go through the CLI slow process every time, provided I already know the correct format, etc. Husky will run after I commit normally, and that should be enough delay for an advanced user. Do you think this should be documented in the repo's README? |
I think we should mention this, because for someone it can be difficult at the beggining to use the convention, especially remember to type yarn commit, but I can agree that this approach isn't the best for people who already knows it and don't have to mess around with it. |
Done in 005e044. |
Describe the solution you'd like
The text was updated successfully, but these errors were encountered: