Feature/#24 faux applications send messages #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
¡¡¡WHY NO WORK NO MORE!!!
Update branch feature/#24
…/github.com/KBS-ASD/message-bus-performance-testing into feature/#24-faux-applications-send-messages
Added green to webshop case
…/github.com/KBS-ASD/message-bus-performance-testing into feature/#24-faux-applications-send-messages
leroykorterink
commented
Dec 17, 2018
Collaborator
Author
leroykorterink
left a comment
leroykorterink
left a comment
There was a problem hiding this comment.
I'd rename the KBS.Messages project to KBS.Contracts, this name is a more descriptive name for the projects purpose.
We should also remove the OldLike message contracts since they're not used anymore.
src/KBS.FauxApplication/TestCases/RequestResponse/Consumers/ResponseConsumer.cs
Outdated
Show resolved
Hide resolved
src/KBS.Messages/RequestResponseCase/RequestResponseMessages.cs
Outdated
Show resolved
Hide resolved
Collaborator
Author
|
The default colors of a console can be changed by a user. Overriding these colors will make the console output hard to read when a user changes the background color to a color that is almost equivalent a custom color. |
…sponseConsumer.cs Co-Authored-By: BramblePie <43555369+BramblePie@users.noreply.github.com>
Co-Authored-By: BramblePie <43555369+BramblePie@users.noreply.github.com>
…com:KBS-ASD/message-bus-performance-testing into feature/#24-faux-applications-send-messages
GerwinvBeek
reviewed
Dec 18, 2018
GerwinvBeek
reviewed
Dec 18, 2018
TestCases/TestCases/RequestResponse/Consumers/ResponseConsumer.cs
Outdated
Show resolved
Hide resolved
TestCases/TestCases/RequestResponse/Consumers/RequestConsumer.cs
Outdated
Show resolved
Hide resolved
BramblePie
approved these changes
Dec 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.