Kassiopeia: Add processing duration as output fields #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To understand which steps and tracks take long to calculate, this commit adds new output fields `processing_duration` to Tracks, Steps, Events and Runs. This replaces the old processing time calculation of KSRuns used to print the estimated remaining time into the log since that can re-use the newly added timings. However this excludes a minor bit of clean-up code after the run processing from the respective timing.
|
Thanks, this is very handy! I have added the output to the DipoleTrapSimulation.xml just now so that users can follow an example when they want to implement this in their simulations. |
richeldichel
force-pushed
the
2xB/timeoutput
branch
from
8041bff
to
9b894f7
Compare
richeldichel
force-pushed
the
2xB/timeoutput
branch
from
9b894f7
to
3d3daf7
Compare
|
I (force) clarified the last commit a bit by naming the corresponding components 'processing_duration' and not 'component_step_duration'. Will merge this now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To understand which steps and tracks take long to calculate, this commit adds new output fields
processing_durationto Tracks, Steps, Events and Runs.This replaces the old processing time calculation of KSRuns used to print the estimated remaining time into the log since that can re-use the newly added timings. However this excludes a minor bit of clean-up code after the run processing from the respective timing.