Mods management #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gmazoyer
force-pushed
the
dependency-management
branch
from
a23f8cb to
981de59
Compare
This version allows to install dependencies defined in a JSON formatted file. Dependencies are installed one by one. Each of them are fetch from a remote file and installed locally given a path. A checksum can be optionaly defined to ensure that the proper files are installed. This will also force them to be re-installed if checksums do not match. Right now, dependencies are fetched and installed in a linear fashion. We may improve this by introducing some parallelism in a near future.
Also provide a way to disable the installation of mods.
gmazoyer
force-pushed
the
dependency-management
branch
from
8ed158b to
6ec6bb7
Compare
Also fix concurrency issue when reading from the slice of installed mods before finishing consuming from channels.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version allows to install mods defined in a JSON formatted
file. Mods are installed one by one. Each of them are fetch from
a remote file and installed locally given a path. A checksum can be
optionaly defined to ensure that the proper files are installed. This
will also force them to be re-installed if checksums do not match.
The process of mods installation goes like:
To know if a mod is already installed and needs re-installing, we leverage the checksum of each file if defined. If there is a checksum mismatch, the mod will be re-downloaded and only the files for which checksums mistmatch are re-installed.
Mods that can be installed are the ones marked as
enabledand the ones these depend on. The providedmods.jsonfile describe how to install KFPatcher and its dependency KFUnflect.Some of the fields for mods are currently not used, but are useful to get a glance at what are those mods and where they are coming from. These fields may be useful in the future if we want to implement some kind of reporting for installed mods.