Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Изменения из aiogram'а и улучшение Ruff'а #14

Merged
merged 2 commits into from
May 15, 2024

Conversation

K1rL3s
Copy link
Owner

@K1rL3s K1rL3s commented May 10, 2024

Fix missing error logging (by @unintended, PR1458)
Bump actions versions (by @Olegt0rr, PR1459)
loosened pydantic upper bound to <2.8 (by @jorenham, PR1460)

Добавил кучу правил для Ruff'а. Посмотрим, что будет :)

Fix missing error logging (by @unintended)
loosened pydantic upper bound to <2.8 (by @jorenham)
Bump actions versions (by @Olegt0rr)
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.92%. Comparing base (94830c2) to head (6de0a62).
Report is 15 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
- Coverage   99.92%   99.92%   -0.01%     
==========================================
  Files         132      132              
  Lines        2533     2528       -5     
==========================================
- Hits         2531     2526       -5     
  Misses          2        2              
Flag Coverage Δ
unittests 99.92% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
aliceio/client/context_controller.py 100.00% <ø> (ø)
aliceio/client/session/aiohttp.py 100.00% <100.00%> (ø)
aliceio/client/session/base.py 100.00% <100.00%> (ø)
aliceio/client/session/middlewares/base.py 100.00% <ø> (ø)
aliceio/dispatcher/dispatcher.py 100.00% <100.00%> (ø)
aliceio/dispatcher/event/alice.py 100.00% <ø> (ø)
aliceio/dispatcher/event/handler.py 100.00% <100.00%> (ø)
aliceio/dispatcher/flags.py 100.00% <ø> (ø)
aliceio/dispatcher/middlewares/base.py 100.00% <ø> (ø)
aliceio/dispatcher/middlewares/error.py 100.00% <100.00%> (ø)
... and 52 more

@Olegt0rr
Copy link

А зачем делать форк и мучаться с портированием обновлений, если можно сделать импорт оригинала и оверрайдить то, что не подходит?

@Olegt0rr
Copy link

Olegt0rr commented May 10, 2024

Странно, что для тестов ставятся зависимости dev (в которых на py38 падает pre-commit, который для тестов и не нужен)

@K1rL3s
Copy link
Owner Author

K1rL3s commented May 10, 2024

А зачем делать форк и мучаться с портированием обновлений, если можно сделать импорт оригинала и оверрайдить то, что не подходит?

Репа без форка сделана, а так да, было бы удобнее

@K1rL3s
Copy link
Owner Author

K1rL3s commented May 10, 2024

Странно, что для тестов ставятся зависимости dev (в которых на py38 падает pre-commit, который для тестов и не нужен)

Докопипастился, получается)
Но интересно, как pre-commit 3.7.0 смог локально на Python 3.8 встать

@K1rL3s K1rL3s merged commit 00d6512 into master May 15, 2024
21 checks passed
@K1rL3s K1rL3s deleted the may-refactor branch May 16, 2024 10:19
@K1rL3s K1rL3s added the enhancement New feature or request label Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants