allow usage of a custom GitLab URL #14
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinAiken
approved these changes
Mar 9, 2018
There was a problem hiding this comment.
This is pretty much my first contribution to a Ruby gem
An absolute fantastic contribution! Added a needed feature, added tests, kept it inline with the way the rest of the code is written, and kept CI green.
I'll give my own blog's cert a run with this later today just as a final sanity check, but as long as it works I'll merge and push out a new release today.
Have you given it a try with your own gitlab instance?
| @@ -1,3 +1,7 @@ | |||
| # 0.2.1 | |||
There was a problem hiding this comment.
- Usually when doing a PR to a gem/library, just put something like
NEXT, and leave it to the maintainers to bump the version.. - Also to follow semvar, this is a new "feature", so I probably should bump it to
0.3.0... but it's such a small feature I'll .z release it
So no worries this time, just a note for the next PRs you send 😄
There was a problem hiding this comment.
Awesome, good to know. Thank you for the feedback!
|
I have used it with my own instance and with the commit I just added, it worked. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add the ability to set a custom GitLab instance in
_config.ymlif you happen to be using Pages in a self-hosted environment.This is pretty much my first contribution to a Ruby gem, so I welcome any feedback on making it better.