fix: load script type errors #3405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustFly1984
reviewed
Feb 6, 2025
| @@ -237,7 +235,11 @@ class LoadScript extends PureComponent<LoadScriptProps, LoadScriptState> { | |||
| override render(): ReactNode { | |||
| return ( | |||
| <> | |||
| <div ref={this.check} /> | |||
| <div | |||
| ref={(el) => { | |||
There was a problem hiding this comment.
please use useCallback for the ref function
There was a problem hiding this comment.
@JustFly1984 ,
Cannot use useCallback inside a class component, but I refactored to follow the same pattern as in packages/react-google-maps-api/src/GoogleMap.tsx
Please review again, thank you.
JustFly1984
requested changes
Feb 6, 2025
JustFly1984
approved these changes
Feb 11, 2025
|
merged and released 2.20.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please explain PR reason
Fix type errors related to React ref for React 19