Skip to content

Include React 19 in peer deps #3389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Include React 19 in peer deps #3389

merged 1 commit into from
Oct 25, 2024

Conversation

memark
Copy link
Contributor

@memark memark commented Oct 12, 2024

Include React 19 in peer deps for api package, as suggested in #3382 (comment).
(Note that only one package actually had React as a peer dep.)

@memark memark changed the title include react 19 in peer deps include React 19 in peer deps Oct 12, 2024
@memark memark changed the title include React 19 in peer deps Include React 19 in peer deps Oct 12, 2024
@memark
Copy link
Contributor Author

memark commented Oct 25, 2024

@JustFly1984 Any further comments on this?

@JustFly1984
Copy link
Owner

please provide a PR and I will merge

@memark
Copy link
Contributor Author

memark commented Oct 25, 2024

I'm not sure I understand. This is the PR, right?

@JustFly1984 JustFly1984 merged commit 6776955 into JustFly1984:develop Oct 25, 2024
@JustFly1984
Copy link
Owner

@memark sorry was under impression it is a issue. merged. will release minor version later

@memark
Copy link
Contributor Author

memark commented Oct 25, 2024

No problem, thanks!

@memark memark deleted the memark/peer-deps-react-19 branch October 25, 2024 07:54
@JustFly1984
Copy link
Owner

released 2.20.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants