Fix division by zero in ChaosToExalted

[JustAzul]

User description

Summary

• safeguard ChaosToExalted for when ExaltedValue is zero

Testing

• npm test (fails: Missing script)

---

https://chatgpt.com/codex/tasks/task_e_6848ac47ee8c8333925188f03d6dcd4a

---

PR Type

Bug fix

---

Description

• Add zero check for ExaltedValue

• Return 0 to prevent division by zero

---

Changes walkthrough 📝

	Relevant files
Bug fix	utils.js Prevent division by zero in ChaosToExalted                              components/utils.js Added guard if ExaltedValue equals zero Return 0 to prevent division by zero +1/-0

---

Need help?

Type /help how to ... in the comments thread for any questions about PR-Agent usage.

Check out the documentation for more information.

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Type Consistency The function returns an integer 0 when ExaltedValue is zero, but returns a float with one decimal place in other cases. This leads to inconsistent return types. Consider returning 0.0 to maintain consistency. if (ExaltedValue === 0) return 0; return parseFloat(parseFloat(ChaosValue / ExaltedValue).toFixed(1)); Redundant parseFloat The code uses nested parseFloat(parseFloat(...).toFixed(1)), which is redundant. You can simplify to parseFloat((ChaosValue / ExaltedValue).toFixed(1)). return parseFloat(parseFloat(ChaosValue / ExaltedValue).toFixed(1));

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Impact
Possible issue	Return signed infinity on zero denominator Return Infinity for non-zero numerators instead of silently returning 0 when the denominator is zero. This preserves correct mathematical behavior and signals overflow. Also handle the sign of ChaosValue. components/utils.js [14] -if (ExaltedValue === 0) return 0; +if (ExaltedValue === 0) return ChaosValue === 0 ? 0 : (ChaosValue > 0 ? Infinity : -Infinity); Suggestion importance[1-10]: 6 __ Why: Returning Infinity or -Infinity more correctly reflects a division by zero and handles the sign of ChaosValue, avoiding silent masking of a potential issue.	Low
General	Simplify nested parseFloat Remove the redundant inner parseFloat since toFixed already returns a string suitable for a single parse. This simplifies the code without altering the result. components/utils.js [15] -return parseFloat(parseFloat(ChaosValue / ExaltedValue).toFixed(1)); +return parseFloat((ChaosValue / ExaltedValue).toFixed(1)); Suggestion importance[1-10]: 4 __ Why: Removing the inner parseFloat simplifies the expression without changing behavior, improving readability for a minor style enhancement.	Low