Add logging on background redeemer#3545
Merged
Merged
Conversation
JustArchi
approved these changes
Feb 5, 2026
JustArchi
added
the
✨ Enhancement
Member
|
LGTM, thanks! 🏆 |
JustArchi
added a commit
that referenced
this pull request
Feb 5, 2026
This is follow-up to #3545 It's assumed that if user drops keys file into ASF's config directory, their intention is to make use of that file in order to add something into ASF. While we filter it out and accept the fact that the file may not represent 1:1 ASF's required input, there should be at least one valid entry to assume that user knows what they're doing. Therefore, deleting the file outright is probably not a good idea, now that we have logging, it's better to leave file as-is and allow user to correct it. Of course, one could also argue that such correction is impossible if 1+ valid entries are found, but that's no longer our concern, user is expected to drop valid file there to begin with, and we're only adding logic for the most obvious kind of mistake, not all mistakes possible.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Changes
Added logging for background redeemer if no keys are found in a pasted .keys file or if the file was empty.
New functionality
Additional info
Right now an empty .keys file or a file with the wrong formatting is silently discarded. (example: KEY TAB GAMENAME)