Skip to content

Commit

Permalink
[jdk-11-migration] mark targets that must stay on java8 for one scald…
Browse files Browse the repository at this point in the history
…ing target

Explicitly mark targets that cannot migrate to java11 as java8, so they will not be affected when the default platform is changed to java11.  Targets that cannot migrate include hadoop and scalding jobs, targets that they depend on, and other special cases.  See https//go.twitter.biz/jdk11migration for detailed migration docs.

This patch is for src/scala/com/twitter/ads/batch/job/targeting/handle_ml/trainer:handle_targeting_training_data_gen-binary and its dependencies.

JIRA Issues: VM-5402

Differential Revision: https://phabricator.twitter.biz/D920109
  • Loading branch information
baroquebobcat authored and jenkins committed Jul 1, 2022
1 parent 9f15cce commit 9d7852d
Show file tree
Hide file tree
Showing 53 changed files with 54 additions and 0 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-app-lifecycle",
Expand Down
1 change: 1 addition & 0 deletions util-app/src/main/java/com/twitter/app/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
java_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = artifact(
org = "com.twitter",
name = "util-app-java",
Expand Down
1 change: 1 addition & 0 deletions util-app/src/main/scala/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["**/*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-app",
Expand Down
1 change: 1 addition & 0 deletions util-cache/src/main/scala/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
# This target exists only to act as an aggregator jar.
sources = ["PantsWorkaroundCache.scala"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-cache",
Expand Down
1 change: 1 addition & 0 deletions util-cache/src/main/scala/com/twitter/cache/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
scala_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-cache-cache",
Expand Down
1 change: 1 addition & 0 deletions util-cache/src/main/scala/com/twitter/cache/caffeine/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
scala_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-cache-caffeine",
Expand Down
1 change: 1 addition & 0 deletions util-codec/src/main/scala/com/twitter/util/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
scala_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-codec",
Expand Down
2 changes: 2 additions & 0 deletions util-core/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ scala_library(
"src/main/scala/com/twitter/util/*.scala",
],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-core-util",
Expand All @@ -51,6 +52,7 @@ scala_library(
# This target exists only to act as an aggregator jar.
name = "scala",
sources = ["src/main/scala/PantsWorkaroundCore.scala"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-core",
Expand Down
1 change: 1 addition & 0 deletions util-core/src/main/java/com/twitter/concurrent/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
java_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = artifact(
org = "com.twitter",
name = "util-core-java-concurrent",
Expand Down
1 change: 1 addition & 0 deletions util-core/src/main/java/com/twitter/io/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
java_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = artifact(
org = "com.twitter",
name = "util-core-java-io",
Expand Down
1 change: 1 addition & 0 deletions util-core/src/main/java/com/twitter/service/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
java_library(
sources = ["*.java"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = artifact(
org = "com.twitter",
name = "util-core-java-service",
Expand Down
1 change: 1 addition & 0 deletions util-core/src/main/java/com/twitter/util/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
java_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = artifact(
org = "com.twitter",
name = "util-core-java",
Expand Down
1 change: 1 addition & 0 deletions util-core/src/main/java/com/twitter/util/javainterop/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
java_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = artifact(
org = "com.twitter",
name = "util-core-java-javainterop",
Expand Down
1 change: 1 addition & 0 deletions util-core/src/main/scala/com/twitter/concurrent/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
scala_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-core-concurrent",
Expand Down
1 change: 1 addition & 0 deletions util-core/src/main/scala/com/twitter/conversions/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
scala_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-core-conversions",
Expand Down
1 change: 1 addition & 0 deletions util-core/src/main/scala/com/twitter/io/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-core-io",
Expand Down
1 change: 1 addition & 0 deletions util-function/src/main/java/com/twitter/function/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
java_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = artifact(
org = "com.twitter",
name = "util-function-java",
Expand Down
1 change: 1 addition & 0 deletions util-hashing/src/main/scala/com/twitter/hashing/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
scala_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-hashing",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
java_library(
sources = ["*.java"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-jackson-annotations",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-jackson-objectmapper-copy",
Expand Down
1 change: 1 addition & 0 deletions util-jackson/src/main/scala/com/twitter/util/jackson/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-jackson-core",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-jackson-caseclass",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-jackson-caseclass-exceptions",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-jackson-serde",
Expand Down
1 change: 1 addition & 0 deletions util-jvm/src/main/scala/com/twitter/jvm/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
scala_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-jvm",
Expand Down
1 change: 1 addition & 0 deletions util-lint/src/main/scala/com/twitter/util/lint/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
scala_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-lint",
Expand Down
1 change: 1 addition & 0 deletions util-logging/src/main/scala/com/twitter/logging/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["**/*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-logging",
Expand Down
1 change: 1 addition & 0 deletions util-reflect/src/main/scala/com/twitter/util/reflect/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
scala_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-reflect",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
scala_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-registry",
Expand Down
1 change: 1 addition & 0 deletions util-routing/src/main/scala/com/twitter/util/routing/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
scala_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-routing",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
scala_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-security",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
scala_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-slf4j",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
scala_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-slf4j-jul-bridge",
Expand Down
1 change: 1 addition & 0 deletions util-stats/src/main/scala/com/twitter/finagle/stats/BUILD
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["**/*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-stats",
Expand Down
1 change: 1 addition & 0 deletions util-tunable/src/main/scala/com/twitter/util/tunable/BUILD
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
scala_library(
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-tunable",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
java_library(
sources = ["*.java"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-validation-java",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
java_library(
sources = ["*.java"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-validation-java-constraints",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-validation-core",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-validation-cfg",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-validation-constraintvalidation",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-validation-conversions",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-validation-engine",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-validation-executable",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-validation-internal",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-validation-internal-constraintvalidation",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-validation-internal-engine",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-validation-internal-metadata-descriptor",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-validation-internal-validators",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-validation-internal-validators-notempty",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-validation-internal-validators-size",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
scala_library(
sources = ["*.scala"],
compiler_option_sets = ["fatal_warnings"],
platform = "java8",
provides = scala_artifact(
org = "com.twitter",
name = "util-validation-metadata",
Expand Down
Loading

0 comments on commit 9d7852d

Please sign in to comment.