Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: exception thrown in Watney API when limitThreads is not set #5

Closed
Jusas opened this issue Apr 13, 2023 · 1 comment
Closed

API: exception thrown in Watney API when limitThreads is not set #5

Jusas opened this issue Apr 13, 2023 · 1 comment
Assignees
@Jusas
Labels
bug Something isn't working watney api

Comments

@Jusas
Copy link
Owner

Jusas commented Apr 13, 2023

Noticed by a user:

API configuration defaults to value 0 for limitThreads if it is not specified at all in the configuration file. This can happen when the user upgrades to the latest version while still using the old config file that does not contain the new parameter.
This causes an exception down the line when the value is about to be used, as 0 threads is just wrong.

Mitigation:

Add line

limitThreads: -1

(or any other valid number > 0) to config.yml to make things work.
@Jusas Jusas added bug Something isn't working watney api labels Apr 13, 2023
@Jusas Jusas self-assigned this Apr 13, 2023
Jusas added a commit that referenced this issue Apr 14, 2023
@Jusas
Watney API: fixed issue #5 (limitThreads)
903c50f
@Jusas
Copy link
Owner Author

Jusas commented Apr 14, 2023

Fixed and v1.2.1 of API released.

@Jusas Jusas closed this as completed Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jusas Jusas

Labels
bug Something isn't working watney api
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Jusas