Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ingest entities and relationships #1

Merged
merged 3 commits into from
Dec 23, 2020

Conversation

eXtremeX
Copy link
Contributor

@eXtremeX eXtremeX commented Dec 14, 2020

This PR includes MalwareBytes' Nebula integration - the entities and relationships that seemed high value/of interest for JupiterOne.

Some links that could be useful to anyone trying to familiarize with MalwareBytes Nebula a bit more:

  1. Nebula's Data sheet
  2. Nebula's API Reference

A lot of back and forth discussion already took place in this Google document.

There is also this document that shows example resources as MB's API returns them and a list of fields we choose to assign to entities - could be useful in figuring out what other fields should be assigned, if something can be changed, and so on.

We don't have any particular questions at this point (mostly thanks to that Google document where we already asked a lot of questions and got the answers), so please just take a look when you can and let us know of your findings! @aiwilliams @ndowmon

The current state of graph:
malwarebytes_graph

P.S @aiwilliams we've asked MB sales rep about users API access - he told us that unless it's listed on the API documentation page it simply means it's not supported and that we could ask the API team if something can be arranged.

@ndowmon ndowmon self-requested a review December 16, 2020 17:16
Copy link
Contributor

@ndowmon ndowmon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @eXtremeX! I spent some time reviewing your PR today since @aiwilliams is out of the office this week. Yet again, another great integration by you. Please let me know what you think about my comments and if you want to discuss anything on a call together.

Cheers!

package.json Outdated Show resolved Hide resolved
src/validateInvocation.ts Outdated Show resolved Hide resolved
src/steps/endpoints.ts Outdated Show resolved Hide resolved
src/steps/endpoints.ts Outdated Show resolved Hide resolved
src/constants.ts Outdated Show resolved Hide resolved
src/client.ts Outdated Show resolved Hide resolved
src/calculateConfig.ts Outdated Show resolved Hide resolved
src/calculateConfig.ts Outdated Show resolved Hide resolved
src/steps/index.test.ts Outdated Show resolved Hide resolved
src/steps/endpoints.ts Outdated Show resolved Hide resolved
@ndowmon ndowmon self-requested a review December 23, 2020 19:54
@ndowmon ndowmon merged commit a6eed03 into JupiterOne:master Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants