Fix #62 by using a Future to time out the request. #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
GregDThomas
force-pushed
the
get-rpc-reply-hangs
branch
2 times, most recently
from
8de7769 to
0b4b66f
Compare
GregDThomas
force-pushed
the
get-rpc-reply-hangs
branch
from
0b4b66f to
6424016
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've just started seeing this problem (though the ticket was raised over three years ago!)
This PR fixes it by using a future with an explicit timeout.
(I've got larger concerns over the age of the underlying SSH library that makes this necessary, but that's a larger change that needs considerably more effort!)